nixpkgs/pkgs/development
Chuck a45b3ad89f
makeWrapper: Remove unused extraFlagsArray feature
There is a bug in this feature: It allows extra arguments to leak in
from the environment. For example:

  $ export extraFlagsArray=date
  $ man ls

Note that you get the man page for date rather than for ls. This happens
because 'man' happens to use a wrapper (to add groff to its PATH).

An attempt to fix this was made in 5ae18574fc in PR #19328 for
issue #2537, but 1. That change didn't actually fix the problem because
it addressed makeWrapper's environment during the build process, not the
constructed wrapper script's environment after installation, and 2. That
change was apparently accidentally lost when merged with 7ff6eec5fd.

Rather than trying to fix the bug again, we remove the extraFlagsArray
feature, since it has never been used in the public repo in the ten
years it has been available.

wrapAclocal continues to use its own, separate flavor of extraFlagsArray
in a more limited context. The analogous bug there was fixed in
4d7d10da6b in 2011.
2019-09-25 09:23:09 -07:00
..
androidndk-pkgs
arduino treewide: use libtinfo.so.5 where needed 2019-09-18 13:57:20 -04:00
beam-modules treewide: remove redundant quotes 2019-09-08 23:38:31 +00:00
bower-modules/generic
compilers Merge branch 'staging-next' into staging 2019-09-24 08:15:01 +02:00
coq-modules treewide: remove redundant quotes 2019-09-08 23:38:31 +00:00
dhall-modules
dotnet-modules/patches
em-modules/generic
go-modules
go-packages
guile-modules
haskell-modules Merge branch 'master' into staging-next 2019-09-24 08:14:34 +02:00
idris-modules
interpreters Merge branch 'staging-next' into staging 2019-09-22 16:39:56 +02:00
java-modules jogl: remove #37364 workaround 2019-09-15 19:00:15 +00:00
libraries qtwebengine: fix build with pulseaudio 13.0 2019-09-24 22:32:30 -04:00
lisp-modules Merge branch 'master' into staging-next 2019-09-24 08:14:34 +02:00
lua-modules Merge branch 'master' into staging-next 2019-09-24 08:14:34 +02:00
misc rappel: unstable-2019-07-08 -> unstable-2019-09-09 2019-09-09 13:32:48 -07:00
mobile treewide: remove redundant quotes 2019-09-08 23:38:31 +00:00
node-packages nodePackages.dockerfile-language-server-nodejs: init at 0.0.21 2019-09-23 10:38:30 +02:00
ocaml-modules Merge branch 'master' into staging-next 2019-09-24 08:14:34 +02:00
perl-modules Re-Revert "Merge branch 'staging-next'" 2019-09-22 09:38:09 +02:00
pharo treewide: remove redundant quotes 2019-09-08 23:38:31 +00:00
pure-modules Re-Revert "Merge branch 'staging-next'" 2019-09-22 09:38:09 +02:00
python-modules Re-revert "awscli: Get rid of runtime -dev dependencies" 2019-09-24 08:15:26 +02:00
r-modules Merge branch 'master' into staging-next 2019-09-24 08:14:34 +02:00
ruby-modules Re-Revert "Merge branch 'staging-next'" 2019-09-22 09:38:09 +02:00
tools makeWrapper: Remove unused extraFlagsArray feature 2019-09-25 09:23:09 -07:00
web Merge staging-next into staging 2019-09-19 17:00:07 +02:00