e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
74 lines
1.9 KiB
Nix
74 lines
1.9 KiB
Nix
{ cmake
|
|
, fetchFromGitLab
|
|
, lib
|
|
, libnotify
|
|
, mkDerivation
|
|
, pkg-config
|
|
, qtbase
|
|
, qtdeclarative
|
|
, qtgraphicaleffects
|
|
, qtquickcontrols2
|
|
, qttools
|
|
, qtwebengine
|
|
, stdenv
|
|
}:
|
|
|
|
mkDerivation rec {
|
|
pname = "MellowPlayer";
|
|
version = "3.6.8";
|
|
|
|
src = fetchFromGitLab {
|
|
owner = "ColinDuquesnoy";
|
|
repo = "MellowPlayer";
|
|
rev = version;
|
|
hash = "sha256-rsF2xQet7U8d4oGU/HgghvE3vvmkxjlGXPBlLD9mWTk=";
|
|
};
|
|
|
|
nativeBuildInputs = [ cmake pkg-config ];
|
|
|
|
buildInputs = [
|
|
libnotify
|
|
qtbase
|
|
qtdeclarative
|
|
qtgraphicaleffects
|
|
qtquickcontrols2
|
|
qttools
|
|
qtwebengine
|
|
];
|
|
|
|
doCheck = true;
|
|
|
|
cmakeFlags = [ "-DBUILD_TESTS=ON" ];
|
|
|
|
preCheck = ''
|
|
# Running the tests requires a location at the home directory for logging.
|
|
export HOME="$NIX_BUILD_TOP/home"
|
|
mkdir -p "$HOME/.local/share/MellowPlayer.Tests/MellowPlayer.Tests/Logs"
|
|
|
|
# Without this, the tests fail because they cannot create the QT Window
|
|
export QT_QPA_PLATFORM=offscreen
|
|
''
|
|
# TODO: The tests are failing because it can't locate QT plugins. Is there a better way to do this?
|
|
+ (builtins.concatStringsSep "\n" (lib.lists.flatten (builtins.map
|
|
(pkg: [
|
|
(lib.optionalString (pkg ? qtPluginPrefix) ''
|
|
export QT_PLUGIN_PATH="${pkg}/${pkg.qtPluginPrefix}"''${QT_PLUGIN_PATH:+':'}$QT_PLUGIN_PATH
|
|
'')
|
|
|
|
(lib.optionalString (pkg ? qtQmlPrefix) ''
|
|
export QML2_IMPORT_PATH="${pkg}/${pkg.qtQmlPrefix}"''${QML2_IMPORT_PATH:+':'}$QML2_IMPORT_PATH
|
|
'')
|
|
]) buildInputs)));
|
|
|
|
meta = with lib; {
|
|
inherit (qtbase.meta) platforms;
|
|
broken = stdenv.hostPlatform.isDarwin; # test build fails, but the project is not maintained anymore
|
|
|
|
description = "Cloud music integration for your desktop";
|
|
mainProgram = "MellowPlayer";
|
|
homepage = "https://gitlab.com/ColinDuquesnoy/MellowPlayer";
|
|
license = licenses.gpl2;
|
|
maintainers = with maintainers; [ kalbasit ];
|
|
};
|
|
}
|