e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
86 lines
2.3 KiB
Nix
86 lines
2.3 KiB
Nix
{ stdenv
|
|
, lib
|
|
, fetchFromGitHub
|
|
, rustPlatform
|
|
, openssl
|
|
, zlib
|
|
, zstd
|
|
, pkg-config
|
|
, python3
|
|
, xorg
|
|
, Libsystem
|
|
, AppKit
|
|
, Security
|
|
, nghttp2
|
|
, libgit2
|
|
, withDefaultFeatures ? true
|
|
, additionalFeatures ? (p: p)
|
|
, testers
|
|
, nushell
|
|
, nix-update-script
|
|
}:
|
|
|
|
let
|
|
version = "0.98.0";
|
|
in
|
|
|
|
rustPlatform.buildRustPackage {
|
|
pname = "nushell";
|
|
inherit version;
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "nushell";
|
|
repo = "nushell";
|
|
rev = version;
|
|
hash = "sha256-0XN26onR4Tk8Ejc/UntdL+b5FPBOoBmDQM0DRommIMo=";
|
|
};
|
|
|
|
cargoHash = "sha256-43V0TnYGG2tyWRIGaohIaoN7dxnY1fle2Bp5lDiFlWg=";
|
|
|
|
nativeBuildInputs = [ pkg-config ]
|
|
++ lib.optionals (withDefaultFeatures && stdenv.hostPlatform.isLinux) [ python3 ]
|
|
++ lib.optionals stdenv.hostPlatform.isDarwin [ rustPlatform.bindgenHook ];
|
|
|
|
buildInputs = [ openssl zstd ]
|
|
++ lib.optionals stdenv.hostPlatform.isDarwin [ zlib Libsystem Security ]
|
|
++ lib.optionals (withDefaultFeatures && stdenv.hostPlatform.isLinux) [ xorg.libX11 ]
|
|
++ lib.optionals (withDefaultFeatures && stdenv.hostPlatform.isDarwin) [ AppKit nghttp2 libgit2 ];
|
|
|
|
buildNoDefaultFeatures = !withDefaultFeatures;
|
|
buildFeatures = additionalFeatures [ ];
|
|
|
|
doCheck = ! stdenv.hostPlatform.isDarwin; # Skip checks on darwin. Failing tests since 0.96.0
|
|
|
|
checkPhase = ''
|
|
runHook preCheck
|
|
(
|
|
# The skipped tests all fail in the sandbox because in the nushell test playground,
|
|
# the tmp $HOME is not set, so nu falls back to looking up the passwd dir of the build
|
|
# user (/var/empty). The assertions however do respect the set $HOME.
|
|
set -x
|
|
HOME=$(mktemp -d) cargo test -j $NIX_BUILD_CORES --offline -- \
|
|
--test-threads=$NIX_BUILD_CORES \
|
|
--skip=repl::test_config_path::test_default_config_path \
|
|
--skip=repl::test_config_path::test_xdg_config_bad \
|
|
--skip=repl::test_config_path::test_xdg_config_empty
|
|
)
|
|
runHook postCheck
|
|
'';
|
|
|
|
passthru = {
|
|
shellPath = "/bin/nu";
|
|
tests.version = testers.testVersion {
|
|
package = nushell;
|
|
};
|
|
updateScript = nix-update-script { };
|
|
};
|
|
|
|
meta = with lib; {
|
|
description = "Modern shell written in Rust";
|
|
homepage = "https://www.nushell.sh/";
|
|
license = licenses.mit;
|
|
maintainers = with maintainers; [ Br1ght0ne johntitor joaquintrinanes ];
|
|
mainProgram = "nu";
|
|
};
|
|
}
|