e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
101 lines
3.4 KiB
Nix
101 lines
3.4 KiB
Nix
{ lib, stdenv, fetchFromGitLab, cmake, ninja, pkg-config, wrapGAppsHook3
|
|
, curl, fuse3, fetchpatch2
|
|
, desktopToDarwinBundle
|
|
, glib, gtk3, gettext, libxkbfile, libX11, python3
|
|
, freerdp3, libssh, libgcrypt, gnutls
|
|
, pcre2, libdbusmenu-gtk3, libappindicator-gtk3
|
|
, libvncserver, libpthreadstubs, libXdmcp, libxkbcommon
|
|
, libsecret, libsoup_3, spice-protocol, spice-gtk, libepoxy, at-spi2-core
|
|
, openssl, gsettings-desktop-schemas, json-glib, libsodium, harfbuzz
|
|
, wayland
|
|
# The themes here are soft dependencies; only icons are missing without them.
|
|
, adwaita-icon-theme
|
|
, withKf5Wallet ? stdenv.hostPlatform.isLinux, libsForQt5
|
|
, withLibsecret ? stdenv.hostPlatform.isLinux
|
|
, withWebkitGtk ? false, webkitgtk_4_1
|
|
, withVte ? true, vte
|
|
}:
|
|
|
|
stdenv.mkDerivation (finalAttrs: {
|
|
pname = "remmina";
|
|
version = "1.4.35";
|
|
|
|
src = fetchFromGitLab {
|
|
owner = "Remmina";
|
|
repo = "Remmina";
|
|
rev = "v${finalAttrs.version}";
|
|
hash = "sha256-0z2fcBnChCBYPxyFm/xpAW0jHaUGA92NQgjt+lWFUnM=";
|
|
};
|
|
|
|
patches = [
|
|
(fetchpatch2 {
|
|
name = "add-a-conditional-check-for-darwin-and-NetBSD.patch";
|
|
url = "https://gitlab.com/Remmina/Remmina/-/commit/3b681398c823e070c7f780166b9d9fc2158e66c1.diff";
|
|
hash = "sha256-Ovdrsl9bftXiuXV+sqvDP9VGuXQZzC5VKOmkYmBXhNA=";
|
|
})
|
|
];
|
|
|
|
nativeBuildInputs = [ cmake ninja pkg-config wrapGAppsHook3 ]
|
|
++ lib.optionals stdenv.hostPlatform.isDarwin [ desktopToDarwinBundle ];
|
|
|
|
buildInputs = [
|
|
curl
|
|
gsettings-desktop-schemas
|
|
glib gtk3 gettext libxkbfile libX11
|
|
freerdp3 libssh libgcrypt gnutls
|
|
pcre2
|
|
libvncserver libpthreadstubs libXdmcp libxkbcommon
|
|
libsoup_3 spice-protocol
|
|
spice-gtk
|
|
libepoxy at-spi2-core
|
|
openssl adwaita-icon-theme json-glib libsodium
|
|
harfbuzz python3
|
|
wayland
|
|
] ++ lib.optionals stdenv.hostPlatform.isLinux [ fuse3 libappindicator-gtk3 libdbusmenu-gtk3 ]
|
|
++ lib.optionals withLibsecret [ libsecret ]
|
|
++ lib.optionals withKf5Wallet [ libsForQt5.kwallet ]
|
|
++ lib.optionals withWebkitGtk [ webkitgtk_4_1 ]
|
|
++ lib.optionals withVte [ vte ];
|
|
|
|
cmakeFlags = [
|
|
"-DWITH_FREERDP3=ON"
|
|
"-DWITH_VTE=${if withVte then "ON" else "OFF"}"
|
|
"-DWITH_TELEPATHY=OFF"
|
|
"-DWITH_AVAHI=OFF"
|
|
"-DWITH_KF5WALLET=${if withKf5Wallet then "ON" else "OFF"}"
|
|
"-DWITH_LIBSECRET=${if withLibsecret then "ON" else "OFF"}"
|
|
"-DWITH_WEBKIT2GTK=${if withWebkitGtk then "ON" else "OFF"}"
|
|
] ++ lib.optionals stdenv.hostPlatform.isDarwin [
|
|
"-DHAVE_LIBAPPINDICATOR=OFF"
|
|
"-DWITH_CUPS=OFF"
|
|
"-DWITH_ICON_CACHE=OFF"
|
|
];
|
|
|
|
env.NIX_CFLAGS_COMPILE = lib.optionalString stdenv.hostPlatform.isDarwin (toString [
|
|
"-DTARGET_OS_IPHONE=0"
|
|
"-DTARGET_OS_WATCH=0"
|
|
]);
|
|
|
|
dontWrapQtApps = true;
|
|
|
|
preFixup = ''
|
|
gappsWrapperArgs+=(
|
|
--set-default SSL_CERT_DIR "/etc/ssl/certs/"
|
|
--prefix LD_LIBRARY_PATH : "${libX11.out}/lib"
|
|
${lib.optionalString stdenv.hostPlatform.isDarwin ''
|
|
--prefix XDG_DATA_DIRS : "$XDG_ICON_DIRS"
|
|
''}
|
|
)
|
|
'';
|
|
|
|
meta = with lib; {
|
|
license = licenses.gpl2Plus;
|
|
homepage = "https://gitlab.com/Remmina/Remmina";
|
|
changelog = "https://gitlab.com/Remmina/Remmina/-/blob/master/CHANGELOG.md#${lib.replaceStrings ["."] [""] finalAttrs.src.rev}";
|
|
description = "Remote desktop client written in GTK";
|
|
mainProgram = "remmina";
|
|
maintainers = with maintainers; [ bbigras melsigl ryantm ];
|
|
platforms = platforms.linux ++ platforms.darwin;
|
|
};
|
|
})
|