While preparing this change, I read the git blame on all of the files I
touched. I saw a working lifetime of building this system which we use
every day and love dearly and keep maintained ourselves. I saw commits
from a 14 year range between 2003 to 2017!! I could not be more thankful
for Eelco's work on building large parts of the foundation of nixpkgs
that all of us rely on now.
However, the end date of that range of the files I looked at the blame
on was 2017. I did not see surviving code from any newer date than that.
Looking at the Git logs, Eelco has been working on other things, and
that's totally fine.
However, it means that our maintenance metadata is out of date on a lot
of packages, and *that*'s the reason I am submitting this change. There
are a lot of packages that don't have anyone with their name on them to
be pinged if they need attention, even if they have had recent activity
(although it is never clear if recent activity was just someone fixing
it because ZHF or because the package actually matters to them).
There are a lot of packages with storied history that maybe don't need
to be in the set anymore at all since they have not been touched in
years; or maybe they are simply finished.
Empty maintainer lists should be a sign that we need to figure out who
maintains it or potentially remove it if it has rotted, and allowing the
maintainer list to be empty if it is already not maintained is part of a
healthy repository ecology.
Either way, I would like to have the maintenance metadata not mislead
anyone into sending Eelco emails about packages he doesn't, in practice,
work on anymore. I have not removed his name from everything; there are
some things that he is the upstream for or has worked on more recently,
for instance, like Nix, which I have left alone.
checkInputs used to be added to nativeBuildInputs. Now we have
nativeCheckInputs to do that instead. Doing this treewide change allows
to keep hashes identical to before the introduction of
nativeCheckInputs.
Commit 49d0a5afd mistakenly inverted when to apply the patch.
Maybe it's not needed anymore, as pkgsMusl.e2fsprogs succeeded for me
even without it, but it looks harmless and better not have it inversed.
This way we also don't cause a mass rebuild :-)
it adds 14mb of dependencies
which can be significant for initrd
without a separate output
$ du -sch $(nix-store -qR ./result-bin) | sort -h
before fuse dep
618K /nix/store/w2id1hwv4vv7hvp4slgsyrydrjbfqdxc-libidn2-2.3.2
698K /nix/store/ki0x4wywp5b7rixwk1miq222wybdl3si-e2fsprogs-1.46.5-bin
732K /nix/store/4nmqxajzaf60yjribkgvj5j54x9yvr1r-bash-5.1-p12
747K /nix/store/8ckxc8biqqfdwyhr0w70jgrcb4h7a4y5-libunistring-0.9.10
853K /nix/store/kx41yd3yyr9bwrsk85fhhx6qhavfwql6-util-linux-2.37.3-lib
2,3M /nix/store/7nkr1kzrj5j6vzq952p35g0vzk747xjz-e2fsprogs-1.46.5
16M /nix/store/4s21k8k7p1mfik0b33r2spq5hq7774k1-glibc-2.33-108
22M total
after fuse dep
38K /nix/store/k15b817jqz4ckp8rp1mgpkvvx78xxp2n-shadow-4.8.1-su
112K /nix/store/bqjh8dc6m5plswxrmmn9x4cpxrrw94lv-zlib-1.2.11
277K /nix/store/nzw0c7ag22mbyc4xrqyy1q1azq9r8kis-audit-2.8.5
285K /nix/store/ka1xx3ldpliww27wmskc1yxlgcfisdyf-libcap-ng-0.8.2
371K /nix/store/mvgg2fk5wwrcmm3wbrjhjn034aivrik2-fuse-2.9.9
618K /nix/store/w2id1hwv4vv7hvp4slgsyrydrjbfqdxc-libidn2-2.3.2
732K /nix/store/4nmqxajzaf60yjribkgvj5j54x9yvr1r-bash-5.1-p12
738K /nix/store/7wi0dn50wgimvfi30i3d4mxz40vcal10-e2fsprogs-1.46.5-bin
747K /nix/store/8ckxc8biqqfdwyhr0w70jgrcb4h7a4y5-libunistring-0.9.10
853K /nix/store/kx41yd3yyr9bwrsk85fhhx6qhavfwql6-util-linux-2.37.3-lib
1,3M /nix/store/043lz8mvyx5vxl058c1i586yqc8ax4ig-glibc-2.33-108-bin
1,7M /nix/store/fpzbv79ak68sh2sh6mag6jym553wfxws-db-4.8.30
2,3M /nix/store/9w5l1zrdd21hjxgjp5jnxxr6jibpjxd4-shadow-4.8.1
2,3M /nix/store/hjmxalhkvvajs2n26b0ry7ns56bh9k9s-e2fsprogs-1.46.5
2,5M /nix/store/ndnqiz3nnifj1blhg9q626xlmkqq1nmh-gcc-10.3.0-lib
2,8M /nix/store/pnp5qkmj8m07jl8pghhglfdczz2840r9-linux-pam-1.5.2
2,9M /nix/store/h25q7c560bchn326363ms2001jjgf338-util-linux-2.37.3-bin
16M /nix/store/4s21k8k7p1mfik0b33r2spq5hq7774k1-glibc-2.33-108
36M total
e2fsprogs: build fuse2fs on linux only
the fuse for macos might be broken
Fixes compilation on non-glibc at minor cost since these are only
used to guard the use of pragmas selectively disabling warnings
based on the GCC version used.
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/e2fsprogs/versions.
These checks were done:
- built on NixOS
- Warning: no invocation of /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin/bin/chattr had a zero exit code or showed the expected version
- /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin/bin/lsattr passed the binary check.
- Warning: no invocation of /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin/bin/compile_et had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin/bin/mk_cmds had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin/bin/badblocks had a zero exit code or showed the expected version
- /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin/bin/debugfs passed the binary check.
- /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin/bin/dumpe2fs passed the binary check.
- Warning: no invocation of /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin/bin/e2freefrag had a zero exit code or showed the expected version
- /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin/bin/e2fsck passed the binary check.
- Warning: no invocation of /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin/bin/e2image had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin/bin/e2label had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin/bin/e2undo had a zero exit code or showed the expected version
- /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin/bin/e4crypt passed the binary check.
- Warning: no invocation of /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin/bin/e4defrag had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin/bin/filefrag had a zero exit code or showed the expected version
- /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin/bin/fsck.ext2 passed the binary check.
- /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin/bin/fsck.ext3 passed the binary check.
- /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin/bin/fsck.ext4 passed the binary check.
- Warning: no invocation of /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin/bin/logsave had a zero exit code or showed the expected version
- /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin/bin/mke2fs passed the binary check.
- /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin/bin/mkfs.ext2 passed the binary check.
- /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin/bin/mkfs.ext3 passed the binary check.
- /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin/bin/mkfs.ext4 passed the binary check.
- Warning: no invocation of /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin/bin/mklost+found had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin/bin/resize2fs had a zero exit code or showed the expected version
- Warning: no invocation of /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin/bin/tune2fs had a zero exit code or showed the expected version
- 12 of 26 passed binary check by having a zero exit code.
- 0 of 26 passed binary check by having the new version present in output.
- found 1.44.2 with grep in /nix/store/3c5r4b2a5cb6cpwr73ahrr03v965hhbg-e2fsprogs-1.44.2-bin
- directory tree listing: https://gist.github.com/78b13b077d5f9da29fc2b256af44e638
- du listing: https://gist.github.com/356acc8c1a54a78ab93172cac717d3d5
