In preparation for the deprecation of `stdenv.isX`.
These shorthands are not conducive to cross-compilation because they
hide the platforms.
Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way
One example of why this is bad and especially affects compiler packages
https://www.github.com/NixOS/nixpkgs/pull/343059
There are too many files to go through manually but a treewide should
get users thinking when they see a `hostPlatform.isX` in a place where it
doesn't make sense.
```
fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is"
fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is"
```
Without the fix build on ncurses-6.3 fails as:
src/client/monitor/status_client_ncurses.c:350:9:
error: format not a string literal and no format arguments [-Werror=format-security]
350 | mvprintw(0, col-l-1, date);
| ^~~~~~~~
Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/burp/versions.
These checks were done:
- built on NixOS
- ran ‘/nix/store/byii5dn5c62s50mg7gz2vjiqhgwa4wlb-burp-2.1.32/bin/vss_strip help’ got 0 exit code
- ran ‘/nix/store/byii5dn5c62s50mg7gz2vjiqhgwa4wlb-burp-2.1.32/bin/bedup -V’ and found version 2.1.32
- ran ‘/nix/store/byii5dn5c62s50mg7gz2vjiqhgwa4wlb-burp-2.1.32/bin/bsparse -V’ and found version 2.1.32
- ran ‘/nix/store/byii5dn5c62s50mg7gz2vjiqhgwa4wlb-burp-2.1.32/bin/burp -v’ and found version 2.1.32
- ran ‘/nix/store/byii5dn5c62s50mg7gz2vjiqhgwa4wlb-burp-2.1.32/bin/burp_ca -h’ got 0 exit code
- ran ‘/nix/store/byii5dn5c62s50mg7gz2vjiqhgwa4wlb-burp-2.1.32/bin/burp_ca --help’ got 0 exit code
- ran ‘/nix/store/byii5dn5c62s50mg7gz2vjiqhgwa4wlb-burp-2.1.32/bin/burp_ca help’ got 0 exit code
- found 2.1.32 with grep in /nix/store/byii5dn5c62s50mg7gz2vjiqhgwa4wlb-burp-2.1.32
- directory tree listing: https://gist.github.com/04574e27524ea2d8cf54af1b381a7277
