Commit 97ed6b4565 broke the systemd-boot
tests (among others) because of the `hwclock -s` invocation. This was
broken for a while, but not noticed because we didn't have a `set -e`
before.
The error
hwclock: select() to /dev/rtc0 to wait for clock tick timed out
MAY be related to an open QEMU bug[1]: I can't reproduce the error on
aarch64-linux and x86_64-linux with `partitionTableType = "legacy";`.
Also, the issue disappears on x86_64-linux when adding `--directisa`.
However, the invocation was added in f73ff0529e
10 years ago which didn't give any reasoning or pointer to what KVM bug
this may be. Given that this must have happened on an ancient version,
we agreed on removing it altogether[2].
[1] https://gitlab.com/qemu-project/qemu/-/issues/1762
[2] https://github.com/NixOS/nixpkgs/pull/354535#issuecomment-2500791222
This is required for `preVM` which can be arbitrary code: e.g.
`vmTools.createEmptyImage` assumes the presence of `$out` in its default
configuration.
Also, before this patch, `preVM` wasn't even set in the
`__structuredAttrs` case.
Closes#334705
Addresses #205690
The main issue was that the output variable (i.e. `$out` and friends)
didn't exist. I figured the easiest way to add those is to source
`stdenv` here. Given that we build another derivation in this builder,
it's pretty likely that `stdenv` gets pulled already, so I don't expect
a real overhead here.
Also, this mounts `/build` into the VM: this is required to make sure
`.attrs.json` & `.attrs.sh` are available. Dropped the mount of `xchg`
into `/tmp` now since it's also part of `/build`.
As buildGoPackage was removed, it is unlikely for attributes of
buildGoModule to get mixed up with those of buildGoPackage.
Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
Overengineered for no good reason, especially since upstream Xen
recommends downstreams to use the latest stable branch anyway (instead
of the pinned release revision)
Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
- Migrates to the new platform declaration style.
- Removes the separate output TODO, as it is an impossible task.
- Removes some superfluous comments.
Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
`xl` needs a full path to the efirom executable.
This does not fix the qemu-dm issue. A stubdom is still required.
Reported-by: HeHongbo <hehongbo@mail.com>
Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
