From 020dfe613db65bb68812c60f02cb6eb81ea27771 Mon Sep 17 00:00:00 2001
From: Anthony ROUSSEL <anthony@roussel.dev>
Date: Sun, 22 Sep 2024 20:23:07 +0200
Subject: [PATCH 1/2] dynamips: migrate to pkgs/by-name, format with
 nixfmt-rfc-style

---
 .../dy/dynamips/package.nix}                  | 32 ++++++++++++-------
 pkgs/top-level/all-packages.nix               |  2 --
 2 files changed, 20 insertions(+), 14 deletions(-)
 rename pkgs/{applications/emulators/dynamips/default.nix => by-name/dy/dynamips/package.nix} (62%)

diff --git a/pkgs/applications/emulators/dynamips/default.nix b/pkgs/by-name/dy/dynamips/package.nix
similarity index 62%
rename from pkgs/applications/emulators/dynamips/default.nix
rename to pkgs/by-name/dy/dynamips/package.nix
index 1abc0dcf5236..c34bd37c0bdd 100644
--- a/pkgs/applications/emulators/dynamips/default.nix
+++ b/pkgs/by-name/dy/dynamips/package.nix
@@ -1,10 +1,11 @@
-{ lib
-, stdenv
-, fetchFromGitHub
-, cmake
-, libelf
-, libpcap
-, nix-update-script
+{
+  lib,
+  stdenv,
+  cmake,
+  fetchFromGitHub,
+  libelf,
+  libpcap,
+  nix-update-script,
 }:
 
 stdenv.mkDerivation rec {
@@ -13,27 +14,34 @@ stdenv.mkDerivation rec {
 
   src = fetchFromGitHub {
     owner = "GNS3";
-    repo = pname;
-    rev = "v${version}";
+    repo = "dynamips";
+    rev = "refs/tags/v${version}";
     hash = "sha256-+h+WsZ/QrDd+dNrR6CJb2uMG+vbUvK8GTxFJZOxknL0=";
   };
 
   nativeBuildInputs = [ cmake ];
-  buildInputs = [ libelf libpcap ];
 
-  cmakeFlags = [ "-DDYNAMIPS_CODE=stable" ];
+  buildInputs = [
+    libelf
+    libpcap
+  ];
+
+  cmakeFlags = [
+    (lib.cmakeFeature "DYNAMIPS_CODE" "stable")
+  ];
 
   passthru = {
     updateScript = nix-update-script { };
   };
 
   meta = with lib; {
-    inherit (src.meta) homepage;
     description = "Cisco router emulator";
     longDescription = ''
       Dynamips is an emulator computer program that was written to emulate Cisco
       routers.
     '';
+    homepage = "https://github.com/GNS3/dynamips";
+    changelog = "https://github.com/GNS3/dynamips/releases/tag/v${version}";
     license = licenses.gpl2Plus;
     mainProgram = "dynamips";
     maintainers = with maintainers; [ primeos ];
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index 66b9c28eeff2..17f42e60209a 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -2545,8 +2545,6 @@ with pkgs;
     inherit (darwin.apple_sdk_11_0.frameworks) AudioUnit Carbon Cocoa;
   };
 
-  dynamips = callPackage ../applications/emulators/dynamips { };
-
   fceux = libsForQt5.callPackage ../applications/emulators/fceux { };
 
   firebird-emu = libsForQt5.callPackage ../applications/emulators/firebird-emu { };

From b595c270db2b9b0355b69de7fa600334d472bf54 Mon Sep 17 00:00:00 2001
From: Anthony ROUSSEL <anthony@roussel.dev>
Date: Sun, 22 Sep 2024 20:29:31 +0200
Subject: [PATCH 2/2] dynamips: add anthonyroussel to maintainers

---
 pkgs/by-name/dy/dynamips/package.nix | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/pkgs/by-name/dy/dynamips/package.nix b/pkgs/by-name/dy/dynamips/package.nix
index c34bd37c0bdd..77f662acb6e1 100644
--- a/pkgs/by-name/dy/dynamips/package.nix
+++ b/pkgs/by-name/dy/dynamips/package.nix
@@ -44,7 +44,10 @@ stdenv.mkDerivation rec {
     changelog = "https://github.com/GNS3/dynamips/releases/tag/v${version}";
     license = licenses.gpl2Plus;
     mainProgram = "dynamips";
-    maintainers = with maintainers; [ primeos ];
+    maintainers = with maintainers; [
+      primeos
+      anthonyroussel
+    ];
     platforms = platforms.linux ++ platforms.darwin;
   };
 }