From 49ef0fd51a366a1256b85c150a47f88ba638aec4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABl=20de=20Kok?= Date: Fri, 7 Aug 2020 16:49:18 +0200 Subject: [PATCH] rocclr: fix build (no OpenCL library is required) rocclr builds fail since CMake was upgraded to 3.18. This version introduces the REQUIRED option of find_library. However rocclr only needs OpenCL headers. This change makes finding an OpenCL library optional again. --- pkgs/development/libraries/rocclr/default.nix | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkgs/development/libraries/rocclr/default.nix b/pkgs/development/libraries/rocclr/default.nix index f1917b8f2c70..6b561b3c9dd5 100644 --- a/pkgs/development/libraries/rocclr/default.nix +++ b/pkgs/development/libraries/rocclr/default.nix @@ -25,7 +25,7 @@ stdenv.mkDerivation rec { nativeBuildInputs = [ cmake rocm-cmake ]; - buildInputs = [ clang rocm-comgr rocm-runtime rocm-thunk clang ]; + buildInputs = [ clang rocm-comgr rocm-runtime rocm-thunk ]; propagatedBuildInputs = [ libelf libglvnd libX11 ]; @@ -34,7 +34,8 @@ stdenv.mkDerivation rec { --replace 'set(ROCCLR_EXPORTS_FILE "''${CMAKE_CURRENT_BINARY_DIR}/amdrocclr_staticTargets.cmake")' \ 'set(ROCCLR_EXPORTS_FILE "''${CMAKE_INSTALL_LIBDIR}/cmake/amdrocclr_staticTargets.cmake")' \ --replace 'set (CMAKE_LIBRARY_OUTPUT_DIRECTORY ''${CMAKE_CURRENT_BINARY_DIR}/lib)' \ - 'set (CMAKE_LIBRARY_OUTPUT_DIRECTORY ''${CMAKE_INSTALL_LIBDIR})' + 'set (CMAKE_LIBRARY_OUTPUT_DIRECTORY ''${CMAKE_INSTALL_LIBDIR})' \ + --replace 'find_library( OpenCL REQUIRED' 'find_library( OpenCL' substituteInPlace device/comgrctx.cpp \ --replace "libamd_comgr.so" "${rocm-comgr}/lib/libamd_comgr.so" '';