libsidplayfp: 2.9.0 -> 2.10.1, modernise (#349889)

pkgs/development/libraries/libsidplayfp/default.nix

@@ -1,38 +1,35 @@
-{ stdenv
+{
-, lib
+  stdenv,
-, fetchFromGitHub
+  lib,
-, makeFontsConf
+  fetchFromGitHub,
-, nix-update-script
+  makeFontsConf,
-, testers
+  nix-update-script,
-, autoreconfHook
+  testers,
-, docSupport ? true
+  autoreconfHook,
-, doxygen
+  docSupport ? true,
-, graphviz
+  doxygen,
-, libexsid
+  graphviz,
-, libgcrypt
+  libexsid,
-, perl
+  libgcrypt,
-, pkg-config
+  perl,
-, unittest-cpp
+  pkg-config,
-, xa
+  unittest-cpp,
+  xa,
 }:
 
 stdenv.mkDerivation (finalAttrs: {
   pname = "libsidplayfp";
-  version = "2.9.0";
+  version = "2.10.1";
 
   src = fetchFromGitHub {
     owner = "libsidplayfp";
     repo = "libsidplayfp";
     rev = "v${finalAttrs.version}";
     fetchSubmodules = true;
-    hash = "sha256-m1bbbtNJvoY6l2+jMbEN/dR9V7LZ4f1lHHGnn0F4bmU=";
+    hash = "sha256-yZ2IiSzl78N/jrhKls/l2klnePJYKU1NCnZcBKUWiuU=";
   };
 
-  outputs = [
+  outputs = [ "out" ] ++ lib.optionals docSupport [ "doc" ];
-    "out"
-  ] ++ lib.optionals docSupport [
-    "doc"
-  ];
 
   postPatch = ''
     patchShebangs .
@@ -40,24 +37,24 @@ stdenv.mkDerivation (finalAttrs: {
 
   strictDeps = true;
 
-  nativeBuildInputs = [
+  nativeBuildInputs =
-    autoreconfHook
+    [
-    perl
+      autoreconfHook
-    pkg-config
+      perl
-    xa
+      pkg-config
-  ] ++ lib.optionals docSupport [
+      xa
-    doxygen
+    ]
-    graphviz
+    ++ lib.optionals docSupport [
-  ];
+      doxygen
+      graphviz
+    ];
 
   buildInputs = [
     libexsid
     libgcrypt
   ];
 
-  checkInputs = [
+  checkInputs = [ unittest-cpp ];
-    unittest-cpp
-  ];
 
   enableParallelBuilding = true;
 
@@ -69,18 +66,16 @@ stdenv.mkDerivation (finalAttrs: {
   ];
 
   # Make Doxygen happy with the setup, reduce log noise
-  FONTCONFIG_FILE = lib.optionalString docSupport (makeFontsConf { fontDirectories = [ ]; });
+  env.FONTCONFIG_FILE = lib.optionalString docSupport (makeFontsConf {
+    fontDirectories = [ ];
+  });
 
   preBuild = ''
     # Reduce noise from fontconfig during doc building
     export XDG_CACHE_HOME=$TMPDIR
   '';
 
-  buildFlags = [
+  buildFlags = [ "all" ] ++ lib.optionals docSupport [ "doc" ];
-    "all"
-  ] ++ lib.optionals docSupport [
-    "doc"
-  ];
 
   doCheck = stdenv.buildPlatform.canExecute stdenv.hostPlatform;
 
@@ -94,7 +89,7 @@ stdenv.mkDerivation (finalAttrs: {
     updateScript = nix-update-script { };
   };
 
-  meta = with lib; {
+  meta = {
     description = "Library to play Commodore 64 music derived from libsidplay2";
     longDescription = ''
       libsidplayfp is a C64 music player library which integrates
@@ -103,9 +98,13 @@ stdenv.mkDerivation (finalAttrs: {
       C64 system and the SID chips.
     '';
     homepage = "https://github.com/libsidplayfp/libsidplayfp";
-    license = with licenses; [ gpl2Plus ];
+    changelog = "https://github.com/libsidplayfp/libsidplayfp/releases/tag/v${finalAttrs.version}";
-    maintainers = with maintainers; [ ramkromberg OPNA2608 ];
+    license = with lib.licenses; [ gpl2Plus ];
-    platforms = platforms.all;
+    maintainers = with lib.maintainers; [
+      ramkromberg
+      OPNA2608
+    ];
+    platforms = lib.platforms.all;
     pkgConfigModules = [
       "libsidplayfp"
       "libstilview"