dev/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

nixos/btrfs: improve default selection of filesystems for autoScrub

Browse Source
This commit is contained in:
Naxdy 2024-05-11 12:10:38 +02:00
parent 804bc033a6
commit d0239a1e50
No known key found for this signature in database
GPG Key ID: CC15075846BCE91B
1 changed files with 18 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
nixos/modules/tasks/filesystems/btrfs.nix
View File

@ -9,10 +9,11 @@ let
mkIf mkIf
optionals optionals
mkDefault mkDefault
mapAttrsToList
nameValuePair nameValuePair
listToAttrs listToAttrs
filterAttrs; filterAttrs
mapAttrsToList
foldl';
inInitrd = config.boot.initrd.supportedFilesystems.btrfs or false; inInitrd = config.boot.initrd.supportedFilesystems.btrfs or false;
inSystem = config.boot.supportedFilesystems.btrfs or false; inSystem = config.boot.supportedFilesystems.btrfs or false;
@ -37,8 +38,9 @@ in
description = '' description = ''
List of paths to btrfs filesystems to regularly call {command}`btrfs scrub` on. List of paths to btrfs filesystems to regularly call {command}`btrfs scrub` on.
Defaults to all mount points with btrfs filesystems. Defaults to all mount points with btrfs filesystems.
If you mount a filesystem multiple times or additionally mount subvolumes, Note that if you have filesystems that span multiple devices (e.g. RAID), you should
you need to manually specify this list to avoid scrubbing multiple times. take care to use the same device for any given mount point and let btrfs take care
of automatically mounting the rest, in order to avoid scrubbing the same data multiple times.
''; '';
}; };
@ -107,12 +109,18 @@ in
} }
]; ];
# This will yield duplicated units if the user mounts a filesystem multiple times # This will remove duplicated units from either having a filesystem mounted multiple
# or additionally mounts subvolumes, but going the other way around via devices would # time, or additionally mounted subvolumes, as well as having a filesystem span
# yield duplicated units when a filesystem spans multiple devices. # multiple devices (provided the same device is used to mount said filesystem).
# This way around seems like the more sensible default. services.btrfs.autoScrub.fileSystems =
services.btrfs.autoScrub.fileSystems = mkDefault (mapAttrsToList (name: fs: fs.mountPoint) let
(filterAttrs (name: fs: fs.fsType == "btrfs") config.fileSystems)); isDeviceInList = list: device: builtins.filter (e: e.device == device) list != [ ];
uniqueDeviceList = foldl' (acc: e: if isDeviceInList acc e.device then acc else acc ++ [ e ]) [ ];
in
mkDefault (map (e: e.mountPoint)
(uniqueDeviceList (mapAttrsToList (name: fs: { mountPoint = fs.mountPoint; device = fs.device; })
(filterAttrs (name: fs: fs.fsType == "btrfs") config.fileSystems))));
# TODO: Did not manage to do it via the usual btrfs-scrub@.timer/.service # TODO: Did not manage to do it via the usual btrfs-scrub@.timer/.service
# template units due to problems enabling the parameterized units, # template units due to problems enabling the parameterized units,