From afacb9d06b9a5de211dbe710a8a1b226df3c6999 Mon Sep 17 00:00:00 2001 From: Dmitry Kalinkin Date: Sat, 28 Dec 2019 20:05:20 -0500 Subject: [PATCH] python3Packages.ipykernel: use pytestCheckHook, enable all tests All tests pass on NixOS. Some still fail on Darwin, but it's a different issue. --- pkgs/development/python-modules/ipykernel/default.nix | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pkgs/development/python-modules/ipykernel/default.nix b/pkgs/development/python-modules/ipykernel/default.nix index 22a61281af26..3258d2259e00 100644 --- a/pkgs/development/python-modules/ipykernel/default.nix +++ b/pkgs/development/python-modules/ipykernel/default.nix @@ -7,7 +7,7 @@ , traitlets , tornado , pythonOlder -, pytest +, pytestCheckHook , nose }: @@ -21,7 +21,6 @@ buildPythonPackage rec { sha256 = "04jx6ihj3zpj4c7acqa14gl37mpdnbgmfm4nvv97xkjc1cz920xm"; }; - checkInputs = [ pytest nose ]; propagatedBuildInputs = [ ipython jupyter_client traitlets tornado ]; # https://github.com/ipython/ipykernel/pull/377 @@ -32,9 +31,10 @@ buildPythonPackage rec { }) ]; - # For failing tests, see https://github.com/ipython/ipykernel/issues/387 - checkPhase = '' - HOME=$(mktemp -d) pytest ipykernel -k "not (test_sys_path or test_sys_path_profile_dir or test_complete)" + checkInputs = [ pytestCheckHook nose ]; + dontUseSetuptoolsCheck = true; + preCheck = '' + export HOME=$(mktemp -d) ''; # Some of the tests use localhost networking.