From 7f805a60d89f8a92050cb035f4c85bb2a441a5aa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladim=C3=ADr=20=C4=8Cun=C3=A1t?= Date: Wed, 2 Nov 2016 17:49:19 +0100 Subject: [PATCH] nodejs: put back a comment about closure size --- pkgs/development/web/nodejs/nodejs.nix | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pkgs/development/web/nodejs/nodejs.nix b/pkgs/development/web/nodejs/nodejs.nix index 236688bd463a..a45a95680b1c 100644 --- a/pkgs/development/web/nodejs/nodejs.nix +++ b/pkgs/development/web/nodejs/nodejs.nix @@ -16,6 +16,10 @@ let sharedConfigureFlags = concatMap (name: [ "--shared-${name}" "--shared-${name}-libpath=${getLib sharedLibDeps.${name}}/lib" + /** Closure notes: we explicitly avoid specifying --shared-*-includes, + * as that would put the paths into bin/nodejs. + * Including pkgconfig in build inputs would also have the same effect! + */ ]) (builtins.attrNames sharedLibDeps); extraConfigFlags = optionals (!enableNpm) [ "--without-npm" ];