From 631cbc3de7aaf244d322111ada656e0bedf55bff Mon Sep 17 00:00:00 2001 From: sternenseemann <0rpkxez4ksa01gb3typccl0i@systemli.org> Date: Mon, 17 May 2021 15:06:37 +0200 Subject: [PATCH] foot: fix evaluation with clang stdenvs To be able to do LTO with clang we need the LTO-capable llvm-ar from libllvm.out (== llvmPackages.llvm) which contains a superset of the llvm bintools. This used to be passed through from stdenv.cc.cc as llvm, but has been renamed to libllvm in 7869d1654517c028aa76fc1dedc9b5ac301a867a. llvm-ar would be in stdenv.cc.bintools.bintools provided that we are using a clang stdenv which uses lld as its linker. In the future we could thus make this inclusion conditional on stdenv.hostPlatform.linker. Note that the build of foot.tests still fails, pending resolution of #123361. --- pkgs/applications/terminal-emulators/foot/default.nix | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkgs/applications/terminal-emulators/foot/default.nix b/pkgs/applications/terminal-emulators/foot/default.nix index 23531908a60f..5062329834c4 100644 --- a/pkgs/applications/terminal-emulators/foot/default.nix +++ b/pkgs/applications/terminal-emulators/foot/default.nix @@ -104,7 +104,9 @@ stdenv.mkDerivation rec { tllist wayland-protocols pkg-config - ] ++ lib.optional stdenv.cc.isClang stdenv.cc.cc.llvm; + ] ++ lib.optionals (compilerName == "clang") [ + stdenv.cc.cc.libllvm.out + ]; buildInputs = [ fontconfig