luakit: hammer

- nixfmt-rfc-style
- finalAttrs
- strictDeps
- no nested with

pkgs/by-name/lu/luakit/package.nix

@@ -1,53 +1,58 @@
-{ lib
+{
-, stdenv
+  lib,
-, fetchFromGitHub
+  fetchFromGitHub,
-, pkg-config
+  glib-networking,
-, wrapGAppsHook3
+  gst_all_1,
-, help2man
+  gtk3,
-, glib-networking
+  help2man,
-, gst_all_1
+  luajit,
-, gtk3
+  luajitPackages,
-, luajitPackages
+  pkg-config,
-, luajit
+  sqlite,
-, sqlite
+  stdenv,
-, webkitgtk_4_0
+  webkitgtk_4_0,
+  wrapGAppsHook3,
 }:
 
 let
   inherit (luajitPackages) luafilesystem;
 in
-stdenv.mkDerivation rec {
+stdenv.mkDerivation (finalAttrs: {
   pname = "luakit";
   version = "2.3.3";
 
   src = fetchFromGitHub {
     owner = "luakit";
-    repo = pname;
+    repo = "luakit";
-    rev = version;
+    rev = finalAttrs.version;
     hash = "sha256-DtoixcLq+ddbacTAo+Qq6q4k1i6thirACw1zqUeOxXo=";
   };
 
   nativeBuildInputs = [
+    luajit
     pkg-config
     help2man
     wrapGAppsHook3
   ];
-  buildInputs = [
+
-    gtk3
+  buildInputs =
+    [
       glib-networking # TLS support
+      gtk3
       luafilesystem
-    luajit
       sqlite
       webkitgtk_4_0
-  ] ++ ( with gst_all_1; [
+    ]
-    gstreamer
+    ++ (with gst_all_1; [
+      gst-libav
+      gst-plugins-bad
       gst-plugins-base
       gst-plugins-good
-    gst-plugins-bad
       gst-plugins-ugly
-    gst-libav
+      gstreamer
     ]);
 
+  strictDeps = true;
 
   # build-utils/docgen/gen.lua:2: module 'lib.lousy.util' not found
   # TODO: why is not this the default? The test runner adds
@@ -66,9 +71,11 @@ stdenv.mkDerivation rec {
     "XDGPREFIX=${placeholder "out"}/etc/xdg"
   ];
 
-  preFixup = let
+  preFixup =
+    let
       luaKitPath = "$out/share/luakit/lib/?/init.lua;$out/share/luakit/lib/?.lua";
-  in ''
+    in
+    ''
       gappsWrapperArgs+=(
         --prefix XDG_CONFIG_DIRS : "$out/etc/xdg"
         --prefix LUA_PATH ';' "${luaKitPath};$LUA_PATH"
@@ -76,10 +83,9 @@ stdenv.mkDerivation rec {
       )
     '';
 
-  meta = with lib; {
+  meta = {
     homepage = "https://luakit.github.io/";
     description = "Fast, small, webkit-based browser framework extensible in Lua";
-    mainProgram = "luakit";
     longDescription = ''
       Luakit is a highly configurable browser framework based on the WebKit web
       content engine and the GTK+ toolkit. It is very fast, extensible with Lua,
@@ -87,8 +93,9 @@ stdenv.mkDerivation rec {
       power users, developers and anyone who wants to have fine-grained control
       over their web browser’s behaviour and interface.
     '';
-    license     = licenses.gpl3Only;
+    license = lib.licenses.gpl3Only;
-    maintainers = [ maintainers.AndersonTorres ];
+    mainProgram = "luakit";
-    platforms   = platforms.unix;
+    maintainers = with lib.maintainers; [ AndersonTorres ];
+    platforms = lib.platforms.unix;
   };
-}
+})