From 14e11862ea76597277de1693015eafdbe2acbe02 Mon Sep 17 00:00:00 2001 From: Michael Weiss Date: Sat, 13 Mar 2021 16:37:13 +0100 Subject: [PATCH] chromium: Remove the enableVaapi flag/option Chromium is still compiled with use_vaapi=true but since M89 the --enable-accelerated-video-decode was replaced with --enable-features=VaapiVideoDecoder. Instead of updating our wrapper it seems like a better idea to drop enableVaapi entirely and let users use commandLineArgs or chrome://flags/ to enable hardware accelerated video decoding. --- pkgs/applications/networking/browsers/chromium/default.nix | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pkgs/applications/networking/browsers/chromium/default.nix b/pkgs/applications/networking/browsers/chromium/default.nix index cf2fedde97e2..c1b5711b02e4 100644 --- a/pkgs/applications/networking/browsers/chromium/default.nix +++ b/pkgs/applications/networking/browsers/chromium/default.nix @@ -13,7 +13,6 @@ , gnomeKeyringSupport ? false , proprietaryCodecs ? true , enableWideVine ? false -, enableVaapi ? false # Disabled by default due to unofficial support , ungoogled ? false # Whether to build chromium or ungoogled-chromium , cupsSupport ? true , pulseSupport ? config.pulseaudio or stdenv.isLinux @@ -167,8 +166,7 @@ in stdenv.mkDerivation { mkdir -p "$out/bin" eval makeWrapper "${browserBinary}" "$out/bin/chromium" \ - --add-flags ${escapeShellArg (escapeShellArg commandLineArgs)} \ - ${lib.optionalString enableVaapi "--add-flags --enable-accelerated-video-decode"} + --add-flags ${escapeShellArg (escapeShellArg commandLineArgs)} ed -v -s "$out/bin/chromium" << EOF 2i