From 0586518f14e63212bb8e87a7af21e11bad4eb68e Mon Sep 17 00:00:00 2001 From: Florian Beeres Date: Thu, 18 Jan 2024 10:18:11 +0100 Subject: [PATCH] oil: fix build on darwin On Darwin `oil` fails to build with an error that is just a warning when building and installing it with the official instructions at https://www.oilshell.org/release/0.19.0/doc/INSTALL.html This commit therefore adds something to NIX_CFLAGS_COMPILE to turn the error into a warning. --- pkgs/shells/oil/default.nix | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pkgs/shells/oil/default.nix b/pkgs/shells/oil/default.nix index 0160fc29b3be..d4cae2e71ef8 100644 --- a/pkgs/shells/oil/default.nix +++ b/pkgs/shells/oil/default.nix @@ -24,6 +24,10 @@ stdenv.mkDerivation rec { strictDeps = true; buildInputs = lib.optional withReadline readline; + # As of 0.19.0 the build generates an error on MacOS (using clang version 16.0.6 in the builder), + # whereas running it outside of Nix with clang version 15.0.0 generates just a warning. The shell seems to + # work just fine though, so we disable the error here. + env.NIX_CFLAGS_COMPILE = lib.optionalString stdenv.cc.isClang "-Wno-error=incompatible-function-pointer-types"; configureFlags = [ "--datarootdir=${placeholder "out"}" ] ++ lib.optionals withReadline [