From 88328bcf2fd153862d8fa0a5f145acc0a04970fb Mon Sep 17 00:00:00 2001 From: Matthieu Coudron <886074+teto@users.noreply.github.com> Date: Mon, 18 Mar 2024 18:28:57 +0100 Subject: [PATCH 1/3] lua overrides, limit the scope of the with; --- pkgs/development/lua-modules/overrides.nix | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/pkgs/development/lua-modules/overrides.nix b/pkgs/development/lua-modules/overrides.nix index e470bef93aad..3e5b700f8cb6 100644 --- a/pkgs/development/lua-modules/overrides.nix +++ b/pkgs/development/lua-modules/overrides.nix @@ -56,7 +56,9 @@ }: final: prev: -with prev; +let + inherit (prev) luaOlder luaAtLeast lua isLuaJIT; +in { argparse = prev.argparse.overrideAttrs(oa: { @@ -202,7 +204,7 @@ with prev; ''; meta.broken = luaOlder "5.1" || luaAtLeast "5.3"; - propagatedBuildInputs = with lib; oa.propagatedBuildInputs ++ optional (!isLuaJIT) luaffi; + propagatedBuildInputs = with lib; oa.propagatedBuildInputs ++ optional (!isLuaJIT) final.luaffi; }); lgi = prev.lgi.overrideAttrs (oa: { @@ -349,7 +351,7 @@ with prev; luaevent = prev.luaevent.overrideAttrs (oa: { propagatedBuildInputs = oa.propagatedBuildInputs ++ [ - luasocket + final.luasocket ]; externalDeps = [ { name = "EVENT"; dep = libevent; } From 461df53427b1a8879ea14d2aede14a882ba4005f Mon Sep 17 00:00:00 2001 From: Matthieu Coudron <886074+teto@users.noreply.github.com> Date: Tue, 2 Apr 2024 21:21:16 +0200 Subject: [PATCH 2/3] luaPackages.ldbus: make override more robust --- pkgs/development/lua-modules/overrides.nix | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/pkgs/development/lua-modules/overrides.nix b/pkgs/development/lua-modules/overrides.nix index 3e5b700f8cb6..3b39c22e55fa 100644 --- a/pkgs/development/lua-modules/overrides.nix +++ b/pkgs/development/lua-modules/overrides.nix @@ -178,10 +178,12 @@ in }); ldbus = prev.ldbus.overrideAttrs (oa: { - luarocksConfig.variables = { - DBUS_DIR = "${dbus.lib}"; - DBUS_ARCH_INCDIR = "${dbus.lib}/lib/dbus-1.0/include"; - DBUS_INCDIR = "${dbus.dev}/include/dbus-1.0"; + luarocksConfig = oa.luarocksConfig // { + variables = { + DBUS_DIR = "${dbus.lib}"; + DBUS_ARCH_INCDIR = "${dbus.lib}/lib/dbus-1.0/include"; + DBUS_INCDIR = "${dbus.dev}/include/dbus-1.0"; + }; }; buildInputs = [ dbus From 97cec92c51184ed53ea4d59325f057b9af402b69 Mon Sep 17 00:00:00 2001 From: Matthieu Coudron <886074+teto@users.noreply.github.com> Date: Tue, 2 Apr 2024 21:51:42 +0200 Subject: [PATCH 3/3] luaPackages.sqlite: fix build --- pkgs/development/lua-modules/overrides.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/development/lua-modules/overrides.nix b/pkgs/development/lua-modules/overrides.nix index 3b39c22e55fa..a793f56f99d0 100644 --- a/pkgs/development/lua-modules/overrides.nix +++ b/pkgs/development/lua-modules/overrides.nix @@ -539,8 +539,8 @@ in buildInputs = [ libuv ]; # Use system libuv instead of building local and statically linking - luarocksConfig.variables = { - WITH_SHARED_LIBUV = "ON"; + luarocksConfig = lib.recursiveUpdate oa.luarocksConfig { + variables = { WITH_SHARED_LIBUV = "ON"; }; }; # we unset the LUA_PATH since the hook erases the interpreter defaults (To fix)