From f9654f451e5a0f25cc7d454d982108dc9c9ac959 Mon Sep 17 00:00:00 2001 From: OPNA2608 Date: Tue, 8 Nov 2022 22:23:10 +0100 Subject: [PATCH] hdr-plus: Drop - Last upstream code change that wasn't an upstreamed fix by a Nixpkgs maintainer in 2020-03-10 - `halide` bumps usually break it - was broken by Halide 10.0.0, initially fix upstreamed by us but according to Hydra on 2022-04-17 it broke again on Halide 10.0.0 (and it hasn't been building on Hydra since then) - has been reported upstream as broken again on Halide 12.0.0 (2021-05-20) - we are now on Halide 14.0.0 with no fix merged or even PR'd - Originally introduced for `megapixels`, which has dropped support for it due to bad results & complications with its integration - With this dependency gone, I have no personal motivation to maintain this package either For these reasons, I'm dropping the package from Nixpkgs. --- .../graphics/hdr-plus/default.nix | 34 ------------------- pkgs/top-level/aliases.nix | 1 + pkgs/top-level/all-packages.nix | 4 --- 3 files changed, 1 insertion(+), 38 deletions(-) delete mode 100644 pkgs/applications/graphics/hdr-plus/default.nix diff --git a/pkgs/applications/graphics/hdr-plus/default.nix b/pkgs/applications/graphics/hdr-plus/default.nix deleted file mode 100644 index 55411e92f7f9..000000000000 --- a/pkgs/applications/graphics/hdr-plus/default.nix +++ /dev/null @@ -1,34 +0,0 @@ -{ lib, stdenv, fetchFromGitHub -, cmake, halide -, libpng, libjpeg, libtiff, libraw -}: - -stdenv.mkDerivation rec { - pname = "hdr-plus"; - version = "unstable-2021-12-10"; - - src = fetchFromGitHub { - owner = "timothybrooks"; - repo = "hdr-plus"; - rev = "0ab70564493bdbcd5aca899b5885505d0c824435"; - sha256 = "sha256-QV8bGxkwFpbNzJG4kmrWwFQxUo2XzLPnoI1e32UmM6g="; - }; - - nativeBuildInputs = [ cmake ]; - - buildInputs = [ halide libpng libjpeg libtiff libraw ]; - - installPhase = '' - for bin in hdrplus stack_frames; do - install -Dm755 $bin $out/bin/$bin - done - ''; - - meta = with lib; { - description = "Burst photography pipeline based on Google's HDR+"; - homepage = "https://www.timothybrooks.com/tech/hdr-plus/"; - license = licenses.mit; - maintainers = with maintainers; [ OPNA2608 ]; - platforms = platforms.all; - }; -} diff --git a/pkgs/top-level/aliases.nix b/pkgs/top-level/aliases.nix index b778cc11bab0..ae42c2cbf66c 100644 --- a/pkgs/top-level/aliases.nix +++ b/pkgs/top-level/aliases.nix @@ -601,6 +601,7 @@ mapAliases ({ hardlink = throw "hardlink was merged into util-linux since 2019-06-14."; # Added 2022-08-12 inherit (harePackages) hare harec; # Added 2022-08-10 hawkthorne = throw "hawkthorne has been removed because it depended on a broken version of love"; # Added 2022-01-15 + hdr-plus = throw "hdr-plus has been removed because it is unmaintained, often breaks and no longer consumed as a dependency"; # Added 2022-11-08 heapster = throw "Heapster is now retired. See https://github.com/kubernetes-retired/heapster/blob/master/docs/deprecation.md"; # Added 2022-04-05 heimdalFull = throw "'heimdalFull' has been renamed to/replaced by 'heimdal'"; # Converted to throw 2022-02-22 heme = throw "heme has been removed: upstream is gone"; # added 2022-02-06 diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 05d687b152e3..7fff5239e67b 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -29095,10 +29095,6 @@ with pkgs; hdhomerun-config-gui = callPackage ../applications/video/hdhomerun-config-gui { }; - hdr-plus = callPackage ../applications/graphics/hdr-plus { - stdenv = clangStdenv; - }; - hedgedoc-cli = callPackage ../tools/admin/hedgedoc-cli { }; heimer = libsForQt5.callPackage ../applications/misc/heimer { };