From 030420030dcd00238420e628d39ab96fcbc12213 Mon Sep 17 00:00:00 2001 From: Anderson Torres Date: Wed, 19 Jul 2023 23:02:01 -0300 Subject: [PATCH] netsurf.browser: add the infamous -fcommon compiler flag --- .../networking/browsers/netsurf/browser.nix | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/pkgs/applications/networking/browsers/netsurf/browser.nix b/pkgs/applications/networking/browsers/netsurf/browser.nix index 72eeda815295..d529ba2f9380 100644 --- a/pkgs/applications/networking/browsers/netsurf/browser.nix +++ b/pkgs/applications/networking/browsers/netsurf/browser.nix @@ -55,6 +55,17 @@ stdenv.mkDerivation rec { ++ optional (uilib == "gtk3") gtk3 ; + # Since at least 2018 AD, GCC and other compilers run in `-fno-common` mode as + # default, in order to comply with C standards and also get rid of some bad + # quality code. Because of this, many codebases that weren't updated need to + # be patched -- or the `-fcommon` flag should be explicitly passed to the + # compiler + + # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85678 + # https://github.com/NixOS/nixpkgs/issues/54506 + + env.NIX_CFLAGS_COMPILE = "-fcommon"; + preConfigure = '' cat < Makefile.conf override NETSURF_GTK_RES_PATH := $out/share/